Skip to content

[feat: chart] implementation of dual y axis for bar, line or area chart#1241

Merged
Bl3f merged 6 commits into
mainfrom
feat/873-dual-axis-charts
Jul 23, 2026
Merged

[feat: chart] implementation of dual y axis for bar, line or area chart#1241
Bl3f merged 6 commits into
mainfrom
feat/873-dual-axis-charts

Conversation

@socallmebertille

@socallmebertille socallmebertille commented Jul 22, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Add mixed type of chart that can draw 3 different types of chart mixed together with 2 possible y axis :
    • series_type — render the serie as bar, line or area and ignore the initial chart_type, which enable multiple types in a unique chart
    • y_axisleft | right
  • Use of component ComposedChart (by recharts, that automatically decide of the min and max axis border if not specified by user or agent)

Demo

image image

Related issue

#873

Review in cubic

@socallmebertille socallmebertille self-assigned this Jul 22, 2026
@socallmebertille
socallmebertille force-pushed the feat/873-dual-axis-charts branch from 9c2b288 to 2b6a39f Compare July 22, 2026 13:10
@github-actions

github-actions Bot commented Jul 22, 2026

Copy link
Copy Markdown
Contributor

🧹 Preview Removed

The preview deployment for this PR has been cleaned up.

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All reported issues were addressed across 22 files

Reply with feedback, questions, or to request a fix.

Re-trigger cubic

Comment thread apps/frontend/src/components/tool-calls/display-chart-edit-dialog.tsx Outdated
Comment thread apps/shared/src/chart-builder.tsx
Comment thread apps/shared/src/chart-builder.tsx
Comment thread apps/backend/src/components/ai/system-prompt.tsx Outdated
Comment thread apps/shared/src/chart-builder.tsx

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All reported issues were addressed across 22 files

Reply with feedback, questions, or to request a fix.

Re-trigger cubic

Comment thread apps/frontend/src/components/tool-calls/display-chart.tsx Outdated
Comment thread apps/shared/src/chart-builder.tsx
Comment thread apps/shared/src/chart-builder.tsx Outdated
Comment thread apps/shared/src/chart-builder.tsx Outdated
Comment thread apps/shared/src/tools/display-chart.ts
Comment thread apps/shared/src/story-segments.ts Outdated
Comment thread apps/frontend/src/components/tool-calls/display-chart-edit-dialog.tsx Outdated

@Bl3f Bl3f left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@socallmebertille
socallmebertille force-pushed the feat/873-dual-axis-charts branch from 8b91051 to be86caa Compare July 23, 2026 12:50
@Bl3f
Bl3f merged commit da1b918 into main Jul 23, 2026
6 checks passed
@Bl3f
Bl3f deleted the feat/873-dual-axis-charts branch July 23, 2026 12:52
@github-actions

Copy link
Copy Markdown
Contributor

🚀 Preview Deployment

URL https://pr-1241-be86caa.preview.getnao.io
Commit be86caa

⚠️ No LLM API keys configured - you'll see the API key setup flow when trying to chat.


Preview will be automatically removed when this PR is closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants